[PATCH] bcm53xx: add support for Asus RT-AC88U

[Rafał Miłecki]

On 04.11.2021 07:52, Rafał Miłecki wrote:
> On 25.10.2021 23:37, Arınç ÜNAL wrote:
>> @@ -8,6 +8,12 @@ netgear,r8000)
>>       ucidef_set_led_usbport "usb2" "USB 2.0" "bcm53xx:white:usb2" "usb1-port2" "usb2-port2"
>>       ucidef_set_led_usbport "usb3" "USB 3.0" "bcm53xx:white:usb3" "usb1-port1" "usb2-port1" "usb4-port1"
>>       ;;
>> +asus,rt-ac88u)
>> +    ucidef_set_led_default "power" "Power" "white:power" "1"
> 
> Do we need that? "power" led seems to be enabled by default by DTS code:
> linux,default-trigger = "default-on";
> 
>> +    ucidef_set_led_netdev "lan" "LAN" "white:lan" "eth1"
> 
> This info should be put in DT but we don't have bindings for that yet.

Actually it seems "trigger-sources" can be used with Ethernet interfaces
as well. So I think what you need is to:

1. Add #trigger-source-cells = <0>; to ethernet@ nodes
2. Add trigger-sources = <&gmac0>; (or another gmac) to the LED node
3. Read trigger-sources in the ledtrig-netdev.c

For a refernece check drivers/usb/core/ledtrig-usbport.c