[PATCH luci] luci-mod-network: split config migration into 2 steps

Sven Roederer devel-sven at geroedel.de
Sun May 30 08:01:45 PDT 2021


Am Samstag, 29. Mai 2021, 18:10:59 CEST schrieb Hauke Mehrtens:
> On 5/29/21 5:25 PM, Rafał Miłecki wrote:
> > 
> > For the sake of simplicity and reliability use 2 steps migration. The
> > downside is that users may get prompted twice to migrate.
> > 
> 
> I tested it in OpenWrt 21.02 doing the migration in one step by clicking
> continue 2 times and also interrupting it in between, both worked.
> 

I just gave it a try from a 21.02-rc1 based config and it looks fine. 
One note: I made PR https://github.com/openwrt/luci/pull/5086 to include a 
hint, that the conversion-dialog might come up multiple times. This will 
prevent confusion of the user, which might expect an endless loop when the 
dialog comes up the 2nd time.

Sven





More information about the openwrt-devel mailing list