[PATCH] realtek-poe: add support for PoE on Realtek switches

Rafał Miłecki zajec5 at gmail.com
Wed May 12 14:14:34 PDT 2021


On 11.05.2021 19:54, John Crispin wrote:
> On 11.05.21 19:51, Rafał Miłecki wrote:
>> On 11.05.2021 19:46, John Crispin wrote:
>>> On 11.05.21 19:45, Rafał Miłecki wrote:
>>>> I'm really tired of dealing with such hacky solutions. Look at netifd,
>>>> DSA and LuCI as example. We ended up with something that noone fully
>>>> understands. Jo - our UI guru - couldn't deal with designing a proper
>>>> UI for that f*cked config syntax. 
>>>
>>> sorry mate, I am not the reason you are having a bad day, so dont vent it out on me.
>>
>> It's just an example of shitty situation we got. Nothing more.
>>
>> I took a good amount of time to provide valuable review for the
>> [PATCH v2] rtl83xx-poe: add package
>>
>> I described problems, missing parts, provided examples how one can
>> solve it. Let's discuss that please. Instead of commenting on one
>> example I provided.
> 
> lulz, why so aggravated ... its about the code not the person ...
> 
> possibly I missed some of your feedback, will review tomorrow, keep the spirit mate and just chill a little ...

Apparently I've used too strong words, I'm sorry for that, that was
unintentional. I was trying to provide strong arguments and f*kup
example in a good faith, but as I understand it, it sounded rude.

I'd like to help adding PoE support in a clean way from the beginning,
I'll come with some ideas and maybe a code later this week. Please hold
on a bit with commiting this code, I hope we can refactor it a bit in a
reasonable time.



More information about the openwrt-devel mailing list