[PATCH v3 1/2] imagebuilder: unset BINARY_FOLDER and DOWNLOAD_FOLDER in final archive

Sven Roederer devel-sven at geroedel.de
Fri May 7 20:44:28 BST 2021


Baptiste,

Am Freitag, 7. Mai 2021, 14:12:21 CEST schrieb Baptiste Jonglez:
> 
> Since these settings are hidden under "Advanced configuration options (for
> developers)", I don't think it's really necessary to leave this kind of
> implicit information, I would prefer having a valid .config file.
> 

Just sent out v4 of this patch including all the mentioned changes.

> Maybe we should even ignore every setting under this "Advanced
> configuration options" menu when generating the SDK and Imagebuilder...
> But these two are a good start.
> 

Not sure what's all inside these options, but seems a good idea. 
Probably then a more niversal way should be used than handling every option 
individually.

Sven






More information about the openwrt-devel mailing list