[PATCH] ubusd: convert tx_queue to linked list

[Arnout Vandecappelle]

On 24/03/2021 09:31, Petr Štetiar wrote:
> Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be> [2021-03-23 16:23:25]:
> 
> Hi,
> 
>> Note that this infinite tx_queue opens the door to a DoS attack.
> 
> memory is not infinite, so I think, that some sensible upper limit should be
> kept. It might be much higher by default since it's dynamic now, but still
> should be capped and lifted if needed.

 I agree, however:

- the limit should be a global one (not per client);
- it should take into account Rx, Tx and monitor buffers;
- it's not exactly simple to implement (or I don't see a simple way to implement
it);
- I don't have time to work on this;
- it's anyway a rather theoretical issue which already exists anyway, as
explained in the commit message;
- the fix is fixing an actual use case that is not theoretical at all (as in, we
have a device that doesn't boot due to this issue).

 Regards,
 Arnout