[PATCH] mwlwifi: remove target dependency

[Daniel Golle]

On Mon, Mar 22, 2021 at 11:14:39PM +0100, Hauke Mehrtens wrote:
> On 3/21/21 10:17 PM, Daniel Golle wrote:
> > Users complained that building images for various mvebu Linksys devices
> > fails when using the ImageBuilder, it complains about the package
> > 'mwlwifi-firmware-88w8964' not being found.
> > 
> > Turns out the package builds fine in mvebu/cortex-a9 images build, but
> > isn't built at all for arm/cortex-a9 packages. This is because we are
> > using the SDK for bcm53xx/generic to build packages for arm/cortex-a9,
> > hence the dependency for @TARGET_mvebu fails.
> > 
> > Remove the target dependency as kmod-mwlwifi as well as firmware
> > packages actually build fine on all platforms (and people might even
> > want to use Marvell mPCIe Wifi on non-mvebu platforms).
> > As a result, the missing 'mwlwifi-firmware-'* packages should become
> > available for arm/cortex-a9 (and all other platforms).
> 
> Does this happen for the kmod or only for the firmware package? If this only
> happens for the firmware package, does it help to add this to the package
> Makefile:
> PKG_FLAGS:=nonshared

It's only the firmware package missing as the kmods are built in phase1.

> 
> I think we only have this problems with the packages build by the 2. phase
> build bot which is shared between different targets with the same CPU. When
> we make it nonshared it should be build together with the target. We had a
> similar problems with the mtd package some time ago.

Yes, adding PKG_FLAGS:=nonshared would solve the problem (and shouldn't
affect the anyway nonshared kmod build in the same package Makefile).
I forgot about that one...

> 
> We should check if there are more places with similar problem.

Other potentially affected packages which do have target dependencies
set but do not have PKG_FLAGS:=nonshared set:

network/utils/ltq-dsl-base
firmware/cypress-nvram

All other non-kmod core packages seem to have nonshared set in case
they got target dependencies.


Cheers


Daniel