[PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added
Jo-Philipp Wich
jo at mein.io
Sat Mar 20 13:05:17 GMT 2021
Hi Hauke,
thanks for looking into it!
I have a couple of remarks...
> [...]
> [ "$(uci -q get uhttpd.main.ubus_socket)" = "/var/run/ubus.sock" ] && {
> uci set uhttpd.main.ubus_socket='/var/run/ubus/ubus.sock'
> uci commit uhttpd
> + reload_config
That might reload other, unrelated changes. It likely isn't that much of
a problem in practise for most users but could interfere with other
provisioning setups or custom logic.
I think it is better if we simply perform a selective /etc/init.d/uhttpd
reload call here.
> }
>
> exit 0
>
More information about the openwrt-devel
mailing list