[PATCH 5/5] mediatek: Add support for Buffalo WSR-2533DHP2

Hauke Mehrtens hauke at hauke-m.de
Mon Mar 15 15:56:56 GMT 2021


On 3/12/21 9:55 PM, Adrian Schmutzler wrote:
> Hi,
> 
>> -----Original Message-----
>> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
>> On Behalf Of Hauke Mehrtens
>> Sent: Mittwoch, 10. März 2021 00:52
>> To: openwrt-devel at lists.openwrt.org
>> Cc: musashino.open at gmail.com; Hauke Mehrtens <hauke at hauke-m.de>
>> Subject: [PATCH 5/5] mediatek: Add support for Buffalo WSR-2533DHP2
> 
> [...]
> 
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		wireless_amber {
>> +			label = "wsr-2533dhp2:amber:wireless";
>> +			gpios = <&pio 2 GPIO_ACTIVE_HIGH>;
>> +		};
> 
> Consider removing the model from the labels here and below ...

I removed the "wsr-2533dhp2:" prefix from the led labels.
I also switched from gpio-keys-polled to gpio-keys, IRQs for GPIOs are 
working.

One of the buttons is a tri-state switch connected to GPIO 1 and 16, it 
used the same Linux code BTN_0 for both GPIOs before, I checked this to 
BTN_0 and BTN_1 now.

Hauke



More information about the openwrt-devel mailing list