[PATCH v2 0/6] realtek: SFP related fixes

Bjørn Mork bjorn at mork.no
Sun Mar 14 08:40:30 GMT 2021


Bjørn Mork <bjorn at mork.no> writes:

> I see I made a mess of this on the list and in patchworks by
> using '--in-reply-to' with git send-email.

Correction:  The problem was that I used '--in-reply-to' with git
format-patch.

The confusing part is that send-email and format-patch have opposite
defaults for '--thread'.  Using '--in-reply-to' works fine with either
as long as '--thread' is enabled.  This is the default with send-email,
but not with format-patch.

There is a hint in the format-patch docs:

          Beware that the default for git send-email is to thread emails
          itself. If you want git format-patch to take care of
          threading, you will want to ensure that threading is disabled
          for git send-email.

So I learned something new about git today as well. I read this as:
"Don't ever use  '--in-reply-to' with format-patch, unless you know what
you do".

And I never do...


Bjørn



More information about the openwrt-devel mailing list