[PATCH 3/6] realtek: need to handle PHY_INTERFACE_MODE_NA for sfps

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Birger Koblitz
> Sent: Mittwoch, 10. März 2021 20:16
> To: openwrt-devel at lists.openwrt.org
> Subject: Re: [PATCH 3/6] realtek: need to handle
> PHY_INTERFACE_MODE_NA for sfps
> 
> Tested and it indeed fixes the problem that SFPs report this mode when
> configures their serdes.
> Please apply,
>   Birger

So, this fact would make a good commit message then?

Best

Adrian

> 
> On 09/03/2021 22:12, Bjørn Mork wrote:
> > Signed-off-by: Bjørn Mork <bjorn at mork.no>
> > ---
> >   target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
> > b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
> > index e0832c42b887..512f5351bf17 100644
> > --- a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
> > +++ b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c
> > @@ -245,6 +245,7 @@ static void rtl83xx_phylink_validate(struct
> dsa_switch *ds, int port,
> >   	pr_debug("In %s port %d", __func__, port);
> >
> >   	if (!phy_interface_mode_is_rgmii(state->interface) &&
> > +	    state->interface != PHY_INTERFACE_MODE_NA &&
> >   	    state->interface != PHY_INTERFACE_MODE_1000BASEX &&
> >   	    state->interface != PHY_INTERFACE_MODE_MII &&
> >   	    state->interface != PHY_INTERFACE_MODE_REVMII &&
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210312/8672068d/attachment.sig>