[PATCH] netifd: bridge: set default value for igmp_snoop

[zheng qian]

Hi Hauke,

Thanks for the review.

I'll add multicast_querier in the patch.



Hauke Mehrtens <hauke at hauke-m.de> 于2021年2月28日周日 上午1:00写道：
>
> On 2/24/21 1:49 AM, sotux82 at gmail.com wrote:
> > From: Zheng Qian <sotux82 at gmail.com>
> >
> > When luci unchecked the igmp snoop option for a bridge, it
> > just delete the igmp_snooping key from the config file.
> > So netifd can't change /sys/devices/virtual/net/br-lan/bridge/multicast_snooping from "1" to "0".
> >
> > This patch will set a default value to false for the bridge
> > option to fix this bug.
> >
> > Signed-off-by: Zheng Qian <sotux82 at gmail.com>
> > ---
> >   bridge.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/bridge.c b/bridge.c
> > index b70d626..464629c 100644
> > --- a/bridge.c
> > +++ b/bridge.c
> > @@ -875,6 +875,7 @@ bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
> >
> >       /* defaults */
> >       cfg->stp = false;
> > +     cfg->igmp_snoop = false;
> >       cfg->forward_delay = 2;
> >       cfg->robustness = 2;
> >       cfg->query_interval = 12500;
> >
>
> The default setting was removed in this change:
> https://git.openwrt.org/?p=project/netifd.git;a=commitdiff;h=52541140f8138e31958cdc3d7e42a4029fa6bbc9
>
> -       cfg->igmp_snoop = true;
> -       cfg->multicast_querier = true;
>
> We should probably also set multicast_querier to false here.
>
> Hauke
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-netifd-bridge-set-default-value-for-igmp_snoop.patch
Type: application/x-patch
Size: 1131 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210302/29509166/attachment.bin>