[PATCH] ramips: replace obsolete mx25l25635f hack

[Chuanhong Guo]

Hi!

On Fri, Jan 22, 2021 at 11:28 AM DENG Qingfang <dqfext at gmail.com> wrote:
>
> Hi,
>
> On Thu, Jan 21, 2021 at 5:37 PM David Bauer <mail at david-bauer.net> wrote:
> >
> > Is this dependent on board design? The need for the old hack should be fixed by
> > this upstream commit [0]. Given that commit adds SNOR_F_4B_OPCODES for the
> > mx25l25635f, it should in turn disable the hack enabled by broken-flash-reset, as
> > this is dependend on 4B opcodes not being supported. [1]
>
> I'm aware of the upstream fix, but some Youku-YK1 users have reported
> their routers cannot survive a reboot on kernel 5.4, but are fine on
> 4.14 (with the mx25l25635f dts hack) [0].

Some Youku-YK1 uses Winbond W25Q256FV, and we used to have
a hack similar to current broken-flash-reset for all W25Q256FV in 4.14.
(It's called 4B_READ_OP or something)
You only need the broken-flash-reset for this specific model.

> So, adding broken-flash-reset serves as a fail-safe.

It's not added as a replacement for "mx25l25635f" compatible string,
so I think it should be dropped from this patch or moved into a
separated one.

-- 
Regards,
Chuanhong Guo