[PATCH 2/2] bcm4908: build flashable & bootable firmware images

Adrian Schmutzler mail at adrianschmutzler.de
Tue Jan 19 13:20:53 EST 2021


> -----Original Message-----
> From: Rafał Miłecki [mailto:rafal at milecki.pl]
> Sent: Dienstag, 19. Januar 2021 19:09
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: 'Rafał Miłecki' <zajec5 at gmail.com>; openwrt-devel at lists.openwrt.org;
> noltari at gmail.com
> Subject: Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware
> images
> 
> On 2021-01-19 12:32, Adrian Schmutzler wrote:
> >> > cp $(KDIR)/bcm63xx-cfe/$(subst
> >> _,$(comma),$(DEVICE_NAME))/cferam.000
> >> > $@-bootfs/
> >> >
> >> > This will remove the additional variable by simply making the
> >> > current soft rule to have matching device definition name and
> >> > compatible a hard one.
> >>
> >> Are you still planning on adding generic COMPATIBLE variable filling
> >> in the include/*.mk ? That would be nice to have I think.
> >
> > I'm not precisely sure what you are referring to here?
> 
> Please check below quote:
> 
> On 2021-01-15 16:18, Adrian Schmutzler wrote:
> > Apart from that (and independent of whether you change the name or
> > not), we should define a default value for this in Device/Default:
> >
> > SUPPORTED_DEVICES := $(subst _,$(comma),$(1)) or COMPATIBLE :=
> $(subst
> > _,$(comma),$(1))
> >
> > This will cover all current cases, and it can easily be overwritten by
> > device-specific definitions where necessary.

I was referring to the Device/Default block in the _target_.

However, having a global SUPPORTED_DEVICES/COMPATIBLE default is actually an interesting idea I will think about now... :-)

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210119/d2d6fc54/attachment.sig>


More information about the openwrt-devel mailing list