[PATCH 2/2] bcm4908: build flashable & bootable firmware images

[Rafał Miłecki]

On 2021-01-18 12:50, Adrian Schmutzler wrote:
>> > Note that if you do apply these two "changes", you get rid of the
>> > COMPATIBLE variable at all for the proposed patch, and this is
>> > probably the reason why a variable like this is not needed for "build
>> > steps" in the other targets (at least those I know closer by now),
>> > which simply use DEVICE_NAME for stuff like that. :-)
>> >
>> > I'd personally prefer going that way, as using DEVICE_NAME would be
>> > more consistent and expectable for this matter.
>> 
>> This is repository started by Álvaro, I just followed existing schema 
>> there.
>> I don't really think I want to start discussion on that and suggest 
>> another
>> naming schema.
>> 
>> One more thing to consider is that more project that just OpenWrt may 
>> want
>> to use that repository. I use it e.g. in my buildroot. Such external 
>> projects
>> may find DTS "compatible" string more common that OpenWrt-specific
>> device name.
> 
> I recently invested a great effort into having DEVICE_NAME and
> compatible consistent on a multitude of targets (except for "," vs.
> "_", obviously).
> 
> So, technically it's not a big difference at the moment anyway. But
> let's live with the current state of the cfe repo here for now.
> 
> However, I'd propose to still get rid of the COMPATIBLE variable and
> construct the cfe name from DEVICE_NAME directly in the Build command:
> 
> cp $(KDIR)/bcm63xx-cfe/$(subst _,$(comma),$(DEVICE_NAME))/cferam.000 
> $@-bootfs/
> 
> This will remove the additional variable by simply making the current
> soft rule to have matching device definition name and compatible a
> hard one.

Are you still planning on adding generic COMPATIBLE variable filling in 
the include/*.mk ? That would be nice to have I think.