No subject

[Daniel Golle]

Hi Etan,

patches look good now, they apply cleanly and don't break the build :)

One minor comment below:

On Wed, Jan 13, 2021 at 01:02:05AM +0100, Etan Kissling via openwrt-devel wrote:
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.

> Date: Wed, 13 Jan 2021 01:02:05 +0100
> From: Etan Kissling <etan_kissling at apple.com>
> To: openwrt-devel at lists.openwrt.org
> Subject: [PATCH] hostapd: add multicast_to_unicast and per_sta_vif
> User-Agent: Microsoft-MacOutlook/16.44.20121301
> 
> This allows configuration of multicast_to_unicast and per_sta_vif options.
> - multicast_to_unicast requests multicast-to-unicast conversion.
> - per_sta_vif assigns each station its own AP_VLAN interface.
> 
> Signed-off-by: Etan Kissling <etan_kissling at apple.com>
> ---
>  package/network/services/hostapd/Makefile       |  2 +-
>  .../network/services/hostapd/files/hostapd.sh   | 17 ++++++++++++++++-
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/package/network/services/hostapd/Makefile b/package/network/services/hostapd/Makefile
> index f57b072974..a6d56d1433 100644
> --- a/package/network/services/hostapd/Makefile
> +++ b/package/network/services/hostapd/Makefile
> @@ -7,7 +7,7 @@
>  include $(TOPDIR)/rules.mk
>  
>  PKG_NAME:=hostapd
> -PKG_RELEASE:=23
> +PKG_RELEASE:=24
>  
>  PKG_SOURCE_URL:=http://w1.fi/hostap.git
>  PKG_SOURCE_PROTO:=git
> diff --git a/package/network/services/hostapd/files/hostapd.sh b/package/network/services/hostapd/files/hostapd.sh
> index 7d9ee5121e..4184926d19 100644
> --- a/package/network/services/hostapd/files/hostapd.sh
> +++ b/package/network/services/hostapd/files/hostapd.sh
> @@ -331,6 +331,10 @@ hostapd_common_add_bss_config() {
>  	config_add_array airtime_sta_weight
>  	config_add_int airtime_bss_weight airtime_bss_limit
>  
> +	config_add_boolean multicast_to_unicast
> +
> +	config_add_boolean per_sta_vif
> +

Please do not create extra lines (and newlines) for those booleans.


>  	config_add_array hostapd_bss_options
>  }
>  
> @@ -480,7 +484,8 @@ hostapd_set_bss_options() {
>  		acct_server acct_secret acct_port acct_interval \
>  		bss_load_update_period chan_util_avg_period sae_require_mfp \
>  		multi_ap multi_ap_backhaul_ssid multi_ap_backhaul_key skip_inactivity_poll \
> -		airtime_bss_weight airtime_bss_limit airtime_sta_weight
> +		airtime_bss_weight airtime_bss_limit airtime_sta_weight \
> +		multicast_to_unicast per_sta_vif
>  
>  	set_default isolate 0
>  	set_default maxassoc 0
> @@ -942,6 +947,16 @@ hostapd_set_bss_options() {
>  		json_for_each_item append_operator_icon operator_icon
>  	fi
>  
> +	set_default multicast_to_unicast 0
> +	if [ "$multicast_to_unicast" -gt 0 ]; then
> +		append bss_conf "multicast_to_unicast=$multicast_to_unicast" "$N"
> +	fi
> +
> +	set_default per_sta_vif 0
> +	if [ "$per_sta_vif" -gt 0 ]; then
> +		append bss_conf "per_sta_vif=$per_sta_vif" "$N"
> +	fi
> +
>  	json_get_values opts hostapd_bss_options
>  	for val in $opts; do
>  		append bss_conf "$val" "$N"
> -- 
> 2.21.1 (Apple Git-122.3)
> 
> 
> 
> 

> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel