No subject

Daniel Golle daniel at makrotopia.org
Tue Jan 12 15:13:17 EST 2021


Hi Etan,

On Tue, Jan 12, 2021 at 01:22:16PM +0100, Etan Kissling (IC) via openwrt-devel wrote:
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.

> Date: Tue, 12 Jan 2021 13:22:16 +0100
> From: "Etan Kissling (IC)" <etan_kissling at apple.com>
> To: openwrt-devel at lists.openwrt.org
> Subject: [PATCH] nf-conntrack: allow querying conntrack info in nfqueue
> X-Mailer: Apple Mail (2.3654.40.0.2.32)
> 
> This allows libnetfilter_queue to access connection tracking information
> by requesting NFQA_CFG_F_CONNTRACK. Connection tracking information is
> provided in the NFQA_CT attribute.
> CONFIG_NETFILTER_NETLINK_GLUE_CT enables the interaction between
> nf_queue and nf_conntrack_netlink. Without this option, trying to access
> connection tracking information results in "Operation not supported".

Unfortunately your contribution got mangled by your mailer
program and cannot be applied like that:

checking file package/kernel/linux/modules/netfilter.mk
patch: **** malformed patch at line 17: CONFIG_NETFILTER_NETLINK_GLUE_CT=3Dy

(all three patches show mangled new-lines and other kinds of
white-space corruption)

Try sending directly using `git send-email` or use a MUA which doesn't
mangle things.

If both of the above is not an option, you may attach the output of
git format-patch as files to an email to the mailinglist. Do this only
as a last resort, as it will limit the amount of people reviewing and
hence makes it less likely for the patches to make it in.


Cheers


Daniel



> 
> Signed-off-by: Etan Kissling <etan_kissling at apple.com>
> ---
>  package/kernel/linux/modules/netfilter.mk | 2 +-
>  target/linux/generic/config-5.4           | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/kernel/linux/modules/netfilter.mk b/package/kernel/linux/modules/netfilter.mk
> index aacf5948b1..b46fcebc08 100644
> --- a/package/kernel/linux/modules/netfilter.mk
> +++ b/package/kernel/linux/modules/netfilter.mk
> @@ -1002,7 +1002,7 @@ $(eval $(call KernelPackage,nfnetlink-queue))
>  define KernelPackage/nf-conntrack-netlink
>    TITLE:=Connection tracking netlink interface
>    FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_netlink.ko
> -  KCONFIG:=CONFIG_NF_CT_NETLINK CONFIG_NF_CONNTRACK_EVENTS=y
> +  KCONFIG:=CONFIG_NF_CT_NETLINK CONFIG_NF_CONNTRACK_EVENTS=y CONFIG_NETFILTER_NETLINK_GLUE_CT=y
>    AUTOLOAD:=$(call AutoProbe,nf_conntrack_netlink)
>    $(call AddDepends/nfnetlink,+kmod-ipt-conntrack)
>  endef
> diff --git a/target/linux/generic/config-5.4 b/target/linux/generic/config-5.4
> index 9006c63ecf..15d235fea5 100644
> --- a/target/linux/generic/config-5.4
> +++ b/target/linux/generic/config-5.4
> @@ -3672,6 +3672,7 @@ CONFIG_NF_CONNTRACK_PROCFS=y
>  # CONFIG_NF_CONNTRACK_ZONES is not set
>  # CONFIG_NF_CT_NETLINK is not set
>  # CONFIG_NF_CT_NETLINK_TIMEOUT is not set
> +# CONFIG_NF_CT_NETLINK_HELPER is not set
>  # CONFIG_NF_CT_PROTO_DCCP is not set
>  # CONFIG_NF_CT_PROTO_GRE is not set
>  # CONFIG_NF_CT_PROTO_SCTP is not set
> -- 
> 2.21.1 (Apple Git-122.3)
> 
> 
> 

> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel




More information about the openwrt-devel mailing list