R: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

[ansuelsmth at gmail.com]

> Hi,
> 
> comments below.
> 
> > [...]
> > @@ -441,6 +441,20 @@ rpc_iwinfo_scan(struct ubus_context *ctx, struct
> ubus_object *obj,
> >  			blobmsg_add_u32(&buf, "quality", e->quality);
> >  			blobmsg_add_u32(&buf, "quality_max", e-
> >quality_max);
> >
> 
> Only add the "ht_operation" table if there actually is ht_operation. I guess
> wrapping it into  if (e->ht_chan_info.primary_chan) { ... } should do it.
> 

I didn't add the check here as we can assume that ht_operation are always present.
Should I add this anyway? 

> > +			t = blobmsg_open_table(&buf, "ht_operation");
> > +			blobmsg_add_u32(&buf, "primary_channel", e-
> >ht_chan_info.primary_chan);
> > +			blobmsg_add_string(&buf, "secondary_channel_offset",
> ht_secondary_offset[e->ht_chan_info.secondary_chan_off]);
> > +			blobmsg_add_u32(&buf, "channel_width",
> ht_chan_width[e->ht_chan_info.chan_width]);
> > +			blobmsg_close_table(&buf, t);
> > +
> > +			if (e->vht_chan_info.center_chan_1) {
> > +				t = blobmsg_open_table(&buf,
> "vht_operation");
> > +				blobmsg_add_u32(&buf, "channel_width",
> vht_chan_width[e->vht_chan_info.chan_width]);
> > +				blobmsg_add_u32(&buf, "center_freq_1", e-
> >vht_chan_info.center_chan_1);
> > +				blobmsg_add_u32(&buf, "center_freq_2", e-
> >vht_chan_info.center_chan_2);
> > +				blobmsg_close_table(&buf, t);
> > +			}
> > +
> >  			rpc_iwinfo_add_encryption("encryption", &e->crypto);
> >
> >  			blobmsg_close_table(&buf, d);
> >
> 
> ~ Jo