[PATCH] ath79/nand: fix factory image generation for Netgear boards

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Paul Fertser
> Sent: Donnerstag, 11. Februar 2021 22:11
> To: openwrt-devel at lists.openwrt.org
> Cc: Paul Fertser <fercerpav at gmail.com>; Marcin Juszkiewicz <marcin-
> openwrt at juszkiewicz.com.pl>
> Subject: [PATCH] ath79/nand: fix factory image generation for Netgear
> boards
> 
> The factory images need to embed specific IDs to pass verification with the
> OEM firmware (including TFTP recovery), so they need to be per-device
> variables.
> 
> Fixes: ab1584a797 ("ath79: netgear: trim down uImage customisations")
> Acked-By: Marcin Juszkiewicz <marcin-openwrt at juszkiewicz.com.pl>
> Signed-off-by: Paul Fertser <fercerpav at gmail.com>
> ---
>  target/linux/ath79/image/nand.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/linux/ath79/image/nand.mk
> b/target/linux/ath79/image/nand.mk
> index 37fcb36937..351239e2b3 100644
> --- a/target/linux/ath79/image/nand.mk
> +++ b/target/linux/ath79/image/nand.mk
> @@ -1,4 +1,4 @@
> -DEVICE_VARS += RAS_ROOTFS_SIZE RAS_BOARD RAS_VERSION
> +DEVICE_VARS += RAS_ROOTFS_SIZE RAS_BOARD RAS_VERSION
> NETGEAR_BOARD_ID
> +NETGEAR_HW_ID

These are in common-netgear.mk. I'd say either just include that file here (like done in generic.mk) or move just the DEVICE_VARS addition to image/Makefile.

Best

Adrian

> 
>  # attention: only zlib compression is allowed for the boot fs  define
> Build/zyxel-buildkerneljffs
> --
> 2.20.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210211/335ec1b9/attachment.sig>