[PATCH v2 1/3] Move mvswitch 88E6060 driver to the ath25

Sergey Ryazanov ryazanov.s.a at gmail.com
Sat Dec 18 08:42:56 PST 2021


On Sat, Dec 18, 2021 at 6:18 PM Bjørn Mork <bjorn at mork.no> wrote:
> Sergey Ryazanov <ryazanov.s.a at gmail.com> writes:
>>  But in this particular case, the
>> particular 88E6060 switch support can not be switched to the DSA
>> implementation because the DSA implementation does not support
>> configuration via the platform data.
>
> Sorry, I missed this part in my previous reply.  I could very well be
> wrong, but I cannot see anything DT specific in the mv88e6060 driver. It
> just calls dsa_register_switch() to load all the config, and that
> function supports both platform data and device tree.

Ouch! I totally forgot that DSA switches have a common platform data
structure (struct dsa_chip_data), and each DSA driver does not have to
provide its own configuration structure. In this case, it looks like
the ath25 kernel part can be easily switched to the DSA
implementation.

Now I can see that the patch description does look misguided. And I
should say sorry for taking a while to figure that out.

If someone of maintainers already took this patch, then please update
the commit message. Or I will send the patch with the updated message
tomorrow.

> But again:  I don't expect you (or anyone else) to put a lot of work
> into this. Just wanted to paint the bike shed red for christmas ;-)

Yes, that was perfectly clear from the first email :) I just wrongly
assumed that the mv88e6060 DSA driver can not be used with the
platform data. Now you have clearly shown that this is possible.
Thanks for this explanation!

-- 
Sergey



More information about the openwrt-devel mailing list