[PATCH v2 1/3] Move mvswitch 88E6060 driver to the ath25

Sergey Ryazanov ryazanov.s.a at gmail.com
Sat Dec 18 06:51:08 PST 2021


Hello Bjørn,

On Sat, Dec 18, 2021 at 2:25 PM Bjørn Mork <bjorn at mork.no> wrote:
> Sergey Ryazanov <ryazanov.s.a at gmail.com> writes:
>> ath25 can not be switched to the DSA implementation due to lack of the
>> DTS support.
>
> I fully understand and accept that this isn't made a priority.  But the
> explanation is misleading. It's definitely *possible* to use a DSA
> driver without DTS.  There are examples in mainline.  So "cannot" is
> wrong.

Yep, I know that in general a DSA switch can be configured via the
platform data as any other device. But in this particular case, the
particular 88E6060 switch support can not be switched to the DSA
implementation because the DSA implementation does not support
configuration via the platform data.

I checked the kernel code and the OpenWrt patches and found the only
board with the 88E6060 switch and this board utilizes DTS for its
configuration:

openwrt $ grep -rn 'mv88e6060'
build_dir/target-mips_mips32_musl/linux-ath25/linux-5.10.87/arch/
openwrt $ grep -rn 'mv88e6060' target/linux/
target/linux/ath79/dts/ar9132_tplink_tl-wr941-v2.dts:68: compatible =
"marvell,mv88e6060";

So, I can not find which example you mean. But I may not have
understood your input. Please explain where I made a mistake?

-- 
Sergey



More information about the openwrt-devel mailing list