[PATCH 00/13] Switch realtek target to upstream platform

Sander Vanheule sander at svanheule.net
Sun Dec 12 11:51:16 PST 2021


Hi Sebastian,

On Sun, 2021-12-12 at 12:38 +0100, Sebastian Gottschall wrote:
> 
> > I have not experienced a single lock-up when booting with this patch, but I also
> > didn't
> > stress-test the machine or even used the switch part. Do you guys have more details on
> > why
> > it locks up, or how exactly these lock-ups can be resolved?
> so far we found out it was related to the ethernet driver. but this is 
> all part of the work we spended into it
> the last months and recently again since i'm back on this projects

If it's most likely caused by the ethernet driver, then I don't think complaining about
vsmp_smp_ops not being sufficient is appropriate here. We didn't touch the ethernet driver
with this patch series, so any of your changes there should still apply.

> > > if you do performance tests
> > > in addition the mainline still uses 4kc as cpu architecture, which is
> > > simply wrong for anything else but 838x
> > Wrong or suboptimal? I don't currently experience any obvious issues, using the same
> > toolchain for 8380, 8390 and 9300.
> below suboptimal. i mean it decreases performance in a significant 
> amount and fixing this issue is more than just easy

If you know since a while that this will be necessary and is an easy win, then please
submit a patch upstream to break up the target into the SoC-families. I'd actually love to
see things like this being submitted by you or Birger!

Generally speaking, I don't see a reason to wait with submitting patches until other parts
have stopped breaking. At least then we can all work from a common code base. I obviously
prefer submitting upstream where possible, but the networking part will be mostly (or
only) OpenWrt for a while still. People could then enjoy a continous stream of
improvements in the snapshot builds, and might be encouraged to try writing some code
themselves.

Best,
Sander





More information about the openwrt-devel mailing list