[PATCH] ath79: drop cs-gpios property

Chuanhong Guo gch981213 at gmail.com
Mon Apr 19 04:21:14 BST 2021


Hi!

On Fri, Apr 16, 2021 at 6:23 PM David Bauer <mail at david-bauer.net> wrote:
>
> Hi,
>
> On 4/16/21 4:12 AM, Chuanhong Guo wrote:
> > Hi!
> >
> > On Fri, Apr 16, 2021 at 4:43 AM David Bauer <mail at david-bauer.net> wrote:
> >>
> >> The spi-ath79 driver performs the chipselect by writing to dedicated
> >> register in the SPI register block. So the GPIO numbers were not used.
> >
> > This is cs-gpios is a hack to override incorrect num_chipselects in spi-ath79
> > driver (which is set to fixed 1). spi-ath79 should be patched to fix
> > this problem
> > before cs-gpios for ar7161/ar7242 devices can be dropped.
>
> Thanks for the hint, i missed ar93xx uses the newer SPI driver.
>
> Looking at spi-ath79, the number of CS lines can be modified using platform
> data, however all datasheets from ar71xx up to qca956x i could get my hand on
> list 3 chipselect lines available - so a patch which sets the CS count to 3
> should be sufficient?

Correct.

-- 
Regards,
Chuanhong Guo



More information about the openwrt-devel mailing list