Regression in auto-mounting mtd squashfs partitions
nbd at nbd.name
Sat Apr 10 16:03:12 BST 2021
On 2021-04-10 16:33, Daniel Golle wrote:
> On Sat, Apr 10, 2021 at 04:04:28PM +0200, Felix Fietkau wrote:
>> Hi Daniel,
>> it seems to me that your commit 2809d0000744 ("kernel: support FIT
>> partition parser on mtdblock devices") is causing a regression in
>> mounting squashfs rootfs when CONFIG_FIT_PARTITION is enabled.
>> The following workaround fixes it, but maybe you can make a better fix,
>> since you're more familiar with the code.
> No, I just forgot that we are also making assumptions about the mtdblock
> device minor number in our own patches...
> The fix looks good to me and certainly won't break devices that are
> actually making of the new external-data FIT images (as ROOT_DEV is
> then set by the FIT block partition parser in a generic way and no
> 'rootfs' MTD partition exists in that case).
> Acked-by: Daniel Golle <daniel at makrotopia.org>
Fix pushed, thanks for the fast reply.
More information about the openwrt-devel