[PATCH] ramips: gpio-ralink: use ngpios, not ralink,num-gpios
sander at svanheule.net
Wed Apr 7 10:46:08 BST 2021
On Mon, 2021-04-05 at 22:53 -0700, Ilya Lipnitskiy wrote:
> DTS properties that match *-gpios are treated specially.
> Use ngpios instead, as most GPIO drivers upstream do.
> Fixes 5.10 DTS errors such as:
> OF: /palmbus at 300000/gpio at 600: could not find phandle
> Fixes DTC warnings such as:
> Warning (gpios_property): /palmbus at 300000/gpio at 600:ralink,num-
> Could not get phandle node for (cell 0)
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy at gmail.com>
> Cc: Daniel Golle <daniel at makrotopia.org>
> diff --git a/target/linux/ramips/patches-5.10/802-GPIO-MIPS-ralink-
> add-gpio-driver-for-ralink-SoC.patch b/target/linux/ramips/patches-
> index 141d29f9401c..c173336924d2 100644
> --- a/target/linux/ramips/patches-5.10/802-GPIO-MIPS-ralink-add-gpio-
> +++ b/target/linux/ramips/patches-5.10/802-GPIO-MIPS-ralink-add-gpio-
> @@ -357,7 +357,7 @@ Cc: linux-gpio at vger.kernel.org
> + return -EINVAL;
> + }
> -+ ngpio = of_get_property(np, "ralink,num-gpios", NULL);
> ++ ngpio = of_get_property(np, "ngpios", NULL);
I guess you just went for the smallest patch that fixes the errors and
warnings? Otherwise, if you use of_property_read_u32() here, you don't
have to deal with be32_to_cpu() later on.
Based on my recent experience with linux-gpio, I think more things
would need to change too, for the driver to be upstream-compatible. But
I don't know what your plans are with this driver, so maybe this quick
fix is sufficient for OpenWrt.
More information about the openwrt-devel