[RFC PATCH] ath79: remove model name from LED labels

Adrian Schmutzler mail at adrianschmutzler.de
Wed Sep 30 16:55:52 EDT 2020


> > As I said in the PR, unfortunately all of this is essentially very unsatisfying at
> the moment. So, what I plan to do with the labels is as much improvement as
> I can get for now.
> my personal opinion: I would skip this intermediate step and work with
> upstream to implement the LED-triggers where needed. Then backport
> these patches and switch to that ABI. Rafał did this with ledtrig-usbport that
> is because I'm not sure how hard the migration for this intermediate step is.
> if much effort is required then I'd rather spend time on something that will
> be usable in the future rather than spending time on some temporary
> solution

Well, upstream isn't ready yet, and based on what it looks like now the upstream solution will make things more complicated at first.
In any case, we will need a whole lot of work both for implementation and migration (as far as I can tell from a concept).

Nevertheless, the removal of the board names is a necessary intermediate step. It will be the same amount of work (actually not much) now or later, but we will have to do it in any case. So let's do it now, so we can get the benefits right now as well. An then let's see whether upstream will reach a state where it becomes usable at some point and try to implement it then.

Best

Adrian



> 
> 
> Best regards,
> Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200930/6a11418d/attachment.sig>


More information about the openwrt-devel mailing list