[RFC PATCH] ath79: remove model name from LED labels

Adrian Schmutzler mail at adrianschmutzler.de
Wed Sep 30 07:43:26 EDT 2020


> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Adrian Schmutzler
> Sent: Sonntag, 27. September 2020 23:55
> To: openwrt-devel at lists.openwrt.org
> Subject: RE: [RFC PATCH] ath79: remove model name from LED labels

Hi all,

since there doesn't seem to be any interest in the subject initially, I'd also be interested if there are any general objections towards dropping "devicename" and using "color:function" scheme on LEDs.

I'd actually be quite happy to get rid of this obstacle that annoyed me consistently throughout my involvement with OpenWrt.

Best

Adrian

> 
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> > On Behalf Of Adrian Schmutzler
> > Sent: Samstag, 26. September 2020 18:25
> > To: openwrt-devel at lists.openwrt.org
> > Subject: [RFC PATCH] ath79: remove model name from LED labels
> >
> > Currently, we request LED labels in OpenWrt to follow the scheme
> >
> >   modelname:color:function
> >
> > However, specifying the modelname at the beginning is actually
> > entirely useless for the devices we support in OpenWrt. On the
> > contrary, having this part actually introduces inconvenience in
> > several aspects:
> 
> I've added the missing 01_leds changes, ramips targets and a few minor
> things and pushed everything to a PR here:
> 
> https://github.com/openwrt/openwrt/pull/3464
> 
> Best
> 
> Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200930/72c92bb1/attachment.sig>


More information about the openwrt-devel mailing list