[PATCH v2 1/2] rules.mk: remove redundant -I/-L

Andre Heider a.heider at gmail.com
Thu Sep 3 11:49:48 EDT 2020


Hi Jo,

On 26/08/2020 08:15, Andre Heider wrote:
> $STAGING_DIR/usr/{include,lib} are already added using the gcc specs file, see
> scripts/patch-specs.sh
> 
> $STAGING_DIR/lib is unused and seems to be a leftover from
> 1f0063b5 "rules.mk: remove "$(STAGING_DIR)/include""
> 
> Signed-off-by: Andre Heider <a.heider at gmail.com>

do these two patches look acceptable now?

Thanks,
Andre

> ---
>   rules.mk | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules.mk b/rules.mk
> index 45d96d6be4..a6615647f9 100644
> --- a/rules.mk
> +++ b/rules.mk
> @@ -174,8 +174,8 @@ TARGET_CFLAGS:=$(TARGET_OPTIMIZATION)$(if $(CONFIG_DEBUG), -g3) $(call qstrip,$(
>   TARGET_CXXFLAGS = $(TARGET_CFLAGS)
>   TARGET_ASFLAGS_DEFAULT = $(TARGET_CFLAGS)
>   TARGET_ASFLAGS = $(TARGET_ASFLAGS_DEFAULT)
> -TARGET_CPPFLAGS:=-I$(STAGING_DIR)/usr/include
> -TARGET_LDFLAGS:=-L$(STAGING_DIR)/usr/lib -L$(STAGING_DIR)/lib
> +TARGET_CPPFLAGS:=
> +TARGET_LDFLAGS:=
>   ifneq ($(CONFIG_EXTERNAL_TOOLCHAIN),)
>   LIBGCC_S_PATH=$(realpath $(wildcard $(call qstrip,$(CONFIG_LIBGCC_ROOT_DIR))/$(call qstrip,$(CONFIG_LIBGCC_FILE_SPEC))))
>   LIBGCC_S=$(if $(LIBGCC_S_PATH),-L$(dir $(LIBGCC_S_PATH)) -lgcc_s)
> 




More information about the openwrt-devel mailing list