[PATCH v4 1/4] ipq806x: add support for Linksys E8350 v1

[Chuanhong Guo]

Hi!

On Tue, Sep 29, 2020 at 2:00 AM Todor Colov <todorcolov at abv.bg> wrote:
> --- a/target/linux/ipq806x/image/Makefile
> +++ b/target/linux/ipq806x/image/Makefile
> @@ -13,6 +13,17 @@ define Build/buffalo-rootfs-cksum
>         ) >> $@
>  endef
>
> +# tune addpattern for Linksys E8350-V1 fw pattern generation
> +define Build/linksys-bin
> +        $(STAGING_DIR_HOST)/bin/addpattern -p $(FW_DEVICE_ID) -v $(FW_VERSION) $(if $(SERIAL),-s $(SERIAL)) -i $@ -o $@.new
> +        mv $@.new $@
> +endef
> +# Use Linksys fw header generator to upgrade openwrt factory image over the native Linksys WEB interface
> +define Build/linksys-addfwhdr
> +        -$(STAGING_DIR_HOST)/bin/addfwhdr -i $@ -o $@.new \
> +               ;mv "$@.new" "$@"
> +endef
> +
>  define Device/Default
>         PROFILES := Default
>         KERNEL_DEPENDS = $$(wildcard $(DTS_DIR)/$$(DEVICE_DTS).dts)
> @@ -122,6 +133,24 @@ define Device/edgecore_ecw5410
>  endef
>  TARGET_DEVICES += edgecore_ecw5410
>
> +define Device/linksys_e8350-v1
> +        $(call Device/LegacyImage)
> +        DEVICE_VENDOR := Linksys
> +        DEVICE_MODEL := E8350
> +        DEVICE_VARIANT := v1
> +        SOC := qcom-ipq8064
> +        FW_VERSION := v1.0.03.003
> +        FW_DEVICE_ID := 8350
> +        PAGESIZE := 2048
> +        BLOCKSIZE := 128k
> +        KERNEL_IN_UBI := 1
> +        IMAGES = factory.bin sysupgrade.ubi
> +        IMAGE/sysupgrade.ubi := append-ubi | check-size 0x04000000 | append-metadata

Could you try the tar sysupgrade package instead? Replace this line with:
IMAGE/sysupgrade.bin = sysupgrade-tar | append-metadata
The resulting sysupgrade.bin should work without other changes.

When ubi image is used for sysupgrade, the entire ubi partition is
reformatted, which is suboptimal.

-- 
Regards,
Chuanhong Guo