[PATCH v1 4/4] ramips: add support for TP-Link MR6400 v4

Filip Moc lede at moc6.cz
Wed Nov 18 15:07:43 EST 2020


Hi Adrian,

I updated patches 1,2,4 to address your comments.

As for this
> > +  DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci kmod-usb-ledtrig-
> > usbport \
> 
> I don't see a usb trigger anywhere? Is this needed?
> 
> > +	kmod-usb-serial kmod-usb-serial-option kmod-usb-net-qmi-wwan
> > uqmi

Indeed usbport ledtrig is not used by default. But since this is router
with embedded LTE module I guess that users would most likely want to
set this trigger to some LED (e.g. wan or some signal LED).
Same could be said for QMI which is in fact not needed by default too.
But I guess that since this is router with embedded LTE module users
will most likely want this installed.

There is a significant difference though. If you reset your device and
your only connection is GSM you can install usbport ledtrig after you
set up your connection. Without qmi you're pretty much doomed.

So I think it's convinient to have usbport ledtrig preinstalled though
when compared to qmi it's far less necessary.
Anyway if different set of packages is preferred I will update it.

Filip





More information about the openwrt-devel mailing list