[PATCH] ubus: fix uhttpd crash

Wojciech Jowsa wojciech.jowsa at gmail.com
Sun Nov 15 04:19:17 EST 2020


Unregister ubus subscriber in notification remove callback.
Without this call, uhttpd crashes when client tries to subscribe to
the ubus object after the object was unregistred and registered again.
It is bacuse the reference to ubus subscriber is not freed but
the memory is cleared in the uh_request_done function.

Signed-off-by: Wojciech Jowsa <wojciech.jowsa at gmail.com>
---
 ubus.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ubus.c b/ubus.c
index cc7447e..619135c 100644
--- a/ubus.c
+++ b/ubus.c
@@ -357,6 +357,8 @@ static void uh_ubus_subscription_notification_remove_cb(struct ubus_context *ctx
 	du = container_of(s, struct dispatch_ubus, sub);
 	cl = container_of(du, struct client, dispatch.ubus);
 
+	ubus_unregister_subscriber(ctx, &du->sub);
+
 	ops->request_done(cl);
 }
 
-- 
2.25.1




More information about the openwrt-devel mailing list