[PATCH 2/2] mvebu: LS421DE: improve the HDD leds

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Daniel González Cabanelas
> Sent: Mittwoch, 11. November 2020 23:25
> To: openwrt-devel at lists.openwrt.org
> Subject: [PATCH 2/2] mvebu: LS421DE: improve the HDD leds
> 
> Improve the HDD LEDs used for disk activity:
>  - Use the labels of the casing for better identification
>  - Use the trigger activity per ata channel

I'd rather not change the LED label for a weak cosmetic reason like this.

If you insist, please add a migration script in case somebody defined a custom trigger, similar to
https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/generic/base-files/etc/uci-defaults/04_led_migration

Best

Adrian

> 
> Signed-off-by: Daniel González Cabanelas <dgcbueu at gmail.com>
> ---
>  .../arch/arm/boot/dts/armada-370-buffalo-ls421de.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/target/linux/mvebu/files/arch/arm/boot/dts/armada-370-
> buffalo-ls421de.dts b/target/linux/mvebu/files/arch/arm/boot/dts/armada-
> 370-buffalo-ls421de.dts
> index 7e070f49dc..d05f290b9d 100644
> --- a/target/linux/mvebu/files/arch/arm/boot/dts/armada-370-buffalo-
> ls421de.dts
> +++ b/target/linux/mvebu/files/arch/arm/boot/dts/armada-370-buffalo-
> ls421de.dts
> @@ -149,18 +149,18 @@
>  			gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
>  		};
> 
> -		hdd1_red {
> -			label = "ls421de:red:hdd1";
> +		disk1_red {
> +			label = "ls421de:red:disk1";
>  			gpios = <&gpio1 29 GPIO_ACTIVE_HIGH>;
>  			default-state = "off";
> -			linux,default-trigger = "disk-activity";
> +			linux,default-trigger = "ata1";
>  		};
> 
> -		hdd2_red {
> -			label = "ls421de:red:hdd2";
> +		disk2_red {
> +			label = "ls421de:red:disk2";
>  			gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>;
>  			default-state = "off";
> -			linux,default-trigger = "disk-activity";
> +			linux,default-trigger = "ata2";
>  		};
>  	};
> 
> --
> 2.29.2
> 
> 
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201111/fdc26c41/attachment.sig>