[PATCH v2 10/10] x86: upgrade: make code comment appear as log lines

Yousong Zhou yszhou4tech at gmail.com
Tue Nov 10 08:43:52 EST 2020


On Tue, 10 Nov 2020 at 19:56, Adrian Schmutzler
<mail at adrianschmutzler.de> wrote:
>
> Hi,
>
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> > On Behalf Of Yousong Zhou
> > Sent: Dienstag, 10. November 2020 03:22
> > To: Adrian Schmutzler <mail at adrianschmutzler.de>; Philip Prindeville
> > <philipp at redfish-solutions.com>
> > Cc: Yousong Zhou <yszhou4tech at gmail.com>; OpenWrt Development List
> > <openwrt-devel at lists.openwrt.org>
> > Subject: [PATCH v2 10/10] x86: upgrade: make code comment appear as log
> > lines
> >
> > This is mainly to make it clear records in/out in the following lines are for
> > extracting boot sectors
> >
> > Before
> >
> >   == upgrade: Reading partition table from bootdisk...
> >   37+26 records in
> >   37+26 records out
> >   == upgrade: Reading partition table from image...
> >
> > After
> >
> >   == upgrade: Reading partition table from bootdisk...
> >   == upgrade: Extract boot sector from the image
> >   37+26 records in
> >   37+26 records out
> >   == upgrade: Reading partition table from image...
>
> technically, the commit message would need to be updated from "==" to date.
> However, having seen the updated output I'm not so sure anymore whether date really makes it nicer.
> For this patch it's just a nitpick, though, I'm sure everybody will understand without changing the message as well.

Thanks for the review.  I will reword the commit message a bit to
reflect the current situation.  v3 coming ;)

Regards,
                yousong



More information about the openwrt-devel mailing list