[PATCH v2] scripts: bundle-libraries.sh: fix broken SDK compiler

Jo-Philipp Wich jo at mein.io
Sun Nov 1 12:41:56 EST 2020


Hi Petr,

> [...]  
> +should_be_patched() {
> +	local bin="$1"
> +
> +	[ -x "$bin" ] || return 1
> +
> +	case "$bin" in
> +		*.so|*.so.[0-9]*)
> +			return 1
> +		;;
> +	*)
> +		file "$bin" | grep -sqE "ELF.*(executable|interpreter)" && return 0

Apart from this apparently inconsistent indentation (tabs vs. spaces?) -
LGTM.

Assuming the white space is straightened out...
Acked-by: Jo-Philipp Wich <jo at mein.io>



More information about the openwrt-devel mailing list