[OpenWrt-Devel] Remove generic OpenWrt copyright spread through files
bjorn at mork.no
Tue Mar 31 13:05:34 EDT 2020
<mail at adrianschmutzler.de> writes:
> I frequently encounter files in the OpenWrt trunk (both Makefiles and files included in images) that contain "generic" Copyright information like:
> # Copyright (C) 2014-2016 OpenWrt.org
> # Copyright (C) 2016 LEDE-Project.org
> By "generic", I'm referring to the fact that this claims OpenWrt copyright inside the OpenWrt projects code, which seems redundant to me.
IANAL, but you might want to consider
> I wonder whether it would be appropriate to remove these "redundant"
> Copyright/license comments. To me, it just looks like a waste of space
> (in case of the board.d file actually space on the device) where it is
> not really conveying any additional information.
Well, personally I find it entertaining every time I find one of those
inside some OEM firmware :-)
Like the nice Marvell based Cisco SG250-08 switch I recently got:
bjorn at miraculix:/tmp/_image_tesla_250_184.108.40.206.bin.extracted/_E0DE0.extracted/_90B6E0.extracted/cpio-root$ grep -r OpenWrt etc/init.d/
etc/init.d/sudo:# Copyright (C) 2014 OpenWrt.org
etc/init.d/ros-init:# Copyright (C) 2014 OpenWrt.org
etc/init.d/ros:# Copyright (C) 2014 OpenWrt.org
etc/init.d/php5-fastcgi:# Copyright (C) 2010-2011 OpenWrt.org
etc/init.d/nginx:# Copyright (C) 2015 OpenWrt.org
etc/init.d/mtplap:# Copyright (C) 2009-2011 OpenWrt.org
etc/init.d/log:# Copyright (C) 2013 OpenWrt.org
etc/init.d/dnsmasq:# Copyright (C) 2007-2012 OpenWrt.org
etc/init.d/dnsmasq: local hostname="$(uci_get system @system hostname OpenWrt)"
etc/init.d/dbus:# Copyright (C) 2007-2011 OpenWrt.org
etc/init.d/boot:# Copyright (C) 2006-2011 OpenWrt.org
etc/init.d/avahi-daemon:# Copyright (C) 2006 OpenWrt.org
etc/init.d/aaaa:# Copyright (C) 2015 OpenWrt.org
This is an important reason to keep the Copyright text, even in files
that go into the image IMHO.
Bjørn (not even a member, but I can always provide an opinion on any
subject anyway :-)
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel