[OpenWrt-Devel] [RFC PATCH] ath9k: enable hardware random number generator.

Petr Štetiar ynezz at true.cz
Sun Mar 1 08:47:31 EST 2020

Rui Salvaterra <rsalvaterra at gmail.com> [2020-03-01 13:39:37]:

> Ah, silly me, you're absolutely right. This is just half the patch, and
> it's perfectly fine the way it is, so I'm not enabling anything new, just
> exposing the existing kconfig. Please ignore my previous email.

Well, I've re-read it again.

Your commit description forget to mention, that you're actually removing ADC
based RNG feeding for ar5k, which is missing in that upstream rng.c.

So commit subject and commit description needs some work. You should consider
as well Felix's remark and if I were your, I would simply handle this via
upstream, once upstreamed, simply backported it to OpenWrt.

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list