[OpenWrt-Devel] [PATCH 1/2] procd: add service instance watchdog

[Petr Štetiar]

Daniel Bailey <danielb at meshplusplus.com> [2020-05-29 18:32:55]:

Hi,

BTW I'm not going to apply this, see my reasoning in the other thread[1], just
reviewing this from the patch content perspective:

1. http://lists.infradead.org/pipermail/openwrt-devel/2020-May/023393.html

> + if (in->watchdog.mode != INSTANCE_WATCHDOG_MODE_DISABLED) {
> + uloop_timeout_set(&in->watchdog.timeout, in->watchdog.freq * 1000);
> + DEBUG(2, "Started instance %s::%s watchdog timer : timeout = %d\n",
> in->srv->name, in->name, in->watchdog.freq);
> + }

This looks like a weird indent, you should follow surrounding code formatting.
I wanted to double check this in my tree, but your patch doesn't apply:

 $ curl https://patchwork.ozlabs.org/series/180315/mbox/ | git am

 Applying: procd: add service instance watchdog
 error: patch fragment without header at line 13: @@ -797,6 +864,7 @@ static struct ubus_method main_object_methods[] = {
 Patch failed at 0001 procd: add service instance watchdog

> + // TODO(danielb): change mode integers to strings (0 = disabled, 1 =
> passive, 2 = active)

Either implement it or remove the TODO comment.

> + // TODO(danielb): change mode from u32 to string (0 = disabled, 1 =
> passive, 2 = active)

Ditto.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel