[OpenWrt-Devel] [PATCH] Do not hard-code IS_TTY in script scripts/feeds

Petr Štetiar ynezz at true.cz
Sat Jun 6 00:57:51 EDT 2020

R. Diez via openwrt-devel <openwrt-devel at lists.openwrt.org> [2020-06-04 14:55:30]:


> I do not know what you did not like in the patch, so I am hoping it is just
> the formatting of the subject line and perhaps that some extra explanation
> is needed. Please find enclosed the new patch version.


> This is actually a trivial patch, please feel free to modify it any way you want.

Please send a patch in proper format, so it can be handled with maintainer
scripts and shows at Patchwork[1] we use for patch handling. Otherwise it is
going to be lost.

> For related information, see here:
> https://bugs.openwrt.org/index.php?do=details&task_id=2086

Good, that's important information and should be added into the commit
description, right above your Signed-off-by:

 Ref: FS#2086


 Fixes: FS#2086

> Subject: [PATCH] build: do not hard-code IS_TTY in script scripts/feeds
> The script was previously assuming that stdin is always a TTY.

It should be obvious from your commit description what is wrong currently, so
why is this fix needed. Nobody wants to read commit logs AND bug reports,
which are not even linked/referenced in the commit description.

Quotting from [2]:

 "it will be committed to the source changelog, so it should explain to a
  competent reader why you made this commit.  Include symptoms of the failure
  you are fixing (log messages, error messages, etc.), it will be useful for
  people searching the commit logs looking for a fix for their issue.  If a
  patch fixes a compile failure, include only the most relevant part of the
  failure log"

> Fixes: FS#2086
> Signed-off-by: R. Diez <rdiezmail-openwrt at yahoo.com>

1. https://patchwork.ozlabs.org/project/openwrt/list/
2. https://openwrt.org/submitting-patches

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list