[OpenWrt-Devel] Subject: [PATCH 1/1] blobmsg_json: allow to add full json files

Adrian Panella ianchi74 at outlook.com
Wed Jun 3 19:38:30 EDT 2020


Is there any documentation on the testing infrastructure being used, and what kind of unit test are expected.
I couldn't find any guide on the wiki, and I'm more familiarized with the Node JS based workflows, and if there is some guide it will be faster than going thru the code.
If you point me in the right direction I can add the corresponding tests.


-----Original Message-----
From: Petr Štetiar <ynezz at true.cz> 
Sent: miércoles, 3 de junio de 2020 05:03 a. m.
To: Adrian Panella <ianchi74 at outlook.com>
Cc: openwrt-devel at lists.openwrt.org
Subject: Re: [OpenWrt-Devel] Subject: [PATCH 1/1] blobmsg_json: allow to add full json files


next time please do:

 $ git format-patch -s1 --subject-prefix "PATCH libubox" ...

as described in https://openwrt.org/submitting-patches

Adrian Panella <ianchi74 at outlook.com> [2020-02-22 20:11:28]:

> Current function "blobmsg_add_json_from_file" only adds json file if 
> it is an object,  and it only returns the properties, not a full object attribute.
> This version allows to read any valid json file and returns the 
> complete corresponding attribute.


>  }

whitespace issue

> +bool blobmsg_add_json_file(struct blob_buf *b,  const char *name, 
> +const char *file) {
> +	struct json_object *obj;
> +	bool ret;
> +	

whitespace issue

Apart from this whitespace nitpicks which I could fix by myself as well, I would like to ask you for adding test case under tests directory for this new function, so we can later assure on CI, that there are no memleaks or other issues in this code and spot any regression later as well.

Please note, that test cases are not mandatory, but it is going to help merge your valuable contribution faster :-) Thanks!

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list