Thu Jun 25 05:52:11 EDT 2020
critical part of many subsystems that "you want anyway (tm)".
Which is sort of true too, but more to this later.
> A proper fix is likely a bit more work (as usual).
This begs the question if a proper fix for a hack makes sense or not.
It's definitely easier to follow kirkwood target and just add the
CONFIG_REGMAP=y to the config of apm821xx/sata and revert the
>> diff --git a/target/linux/generic/hack-4.14/259-regmap_dynamic.patch b/target/linux/generic/hack-4.14/259-regmap_dynamic.patch
>> index 1c6e78df30..35803c3181 100644
>> --- a/target/linux/generic/hack-4.14/259-regmap_dynamic.patch
>> +++ b/target/linux/generic/hack-4.14/259-regmap_dynamic.patch
>> @@ -96,6 +97,15 @@ Signed-off-by: Felix Fietkau <nbd at nbd.name>
>> +--- a/drivers/regulator/Kconfig
>> ++++ b/drivers/regulator/Kconfig
>> +@@ -1,5 +1,6 @@
>> + menuconfig REGULATOR
>> + bool "Voltage and Current Regulator Support"
>> ++ select REGMAP
> This will cause REGMAP to be included regardless if needed or not, but
> would be acceptable (at least to me) as an interim build fix (most
> targets using REGULATORs likely won't be part of the 4/32 gang
Yes exactly that is the idea. I did make that patch with ar71xx + tiny
and ramips rt288x/rt305x in mind. The situation is a little bit different
with ath79-tiny as its config-4.14 already sets:
And it inherits the CONFIG_REGMAP=y from the main ath79 config.
If the REGMAP=y is only needed there because of the REGULATOR_FIXED_VOLTAGE
(which does not need it), then it could make sense to extend the hack for
this special case. In order to keep the kernel image as small as possible.
> The correct fix is likely to
> a) add this REGMAP select to all REGULATOR drivers depending on/using
> it (this can probably even be upstreamed)
More information about the openwrt-devel