[PATCH] hostapd: improve TITLE for packages
mail at adrianschmutzler.de
mail at adrianschmutzler.de
Thu Jul 30 09:52:29 EDT 2020
Hi,
> > define Package/wpa-supplicant-openssl $(call
> > Package/wpa-supplicant/Default,$(1))
> > + TITLE+= (OpenSSL)
>
> shouldn't this rather be '(OpenSSL full)' as well then?
>
> > VARIANT:=supplicant-full-openssl
> > DEPENDS+=+libopenssl
> > endef
> >
> > define Package/wpa-supplicant-wolfssl $(call
> > Package/wpa-supplicant/Default,$(1))
> > + TITLE+= (wolfSSL)
>
> shouldn't this rather be '(wolfSSL full)' as well then?
Indeed, good find, will change both cases above as suggested.
> And what about the '(built-in full)' variant of wpa_supplicant?
Err, yes, to follow the current scheme I should add a "(full)" there as well.
Would you prefer to use "(built-in full)" instead of plain "(full)" in all non-SSL cases?
This might actually be more helpful to differentiate.
Thanks
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200730/182af165/attachment.sig>
More information about the openwrt-devel
mailing list