[PATCH v2] zram-swap: explicitely use mkswap/swapon/swapoff from /sbin

Henrique de Moraes Holschuh henrique at nic.br
Fri Jul 24 11:51:32 EDT 2020


On 24/07/2020 12:07, Rui Salvaterra wrote:
> The required BusyBox applets are enabled by default, so we can rely on them
> being present in the system. This way, we make sure there are no conflicts with

Hmm, why not fix this for *good* and not depend on they being enabled in 
busybox "by default"?

I'd just depend on the required busybox features and applets explicitly 
(or select them) *on top of what your patch already does*.

While depends and selects are not always effective for busybox features, 
it *is* the proper build-time machine-readable documentation of the 
package requirements...  And it does work for anyone doing full builds.

-- 
Henrique de Moraes Holschuh



More information about the openwrt-devel mailing list