[PATCH firewall3] zones: apply tcp mss clamping also on ingress path

[Jo-Philipp Wich]

Hi Yousong,


On 7/23/20 6:05 AM, Yousong Zhou wrote:
> Fixes FS#3231
> 
> Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> ---
>  zones.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/zones.c b/zones.c
> index 68b02ab..d5e756c 100644
> --- a/zones.c
> +++ b/zones.c
> @@ -580,6 +580,14 @@ print_interface_rule(struct fw3_ipt_handle *handle, struct fw3_state *state,
>  			fw3_ipt_rule_target(r, "TCPMSS");
>  			fw3_ipt_rule_addarg(r, false, "--clamp-mss-to-pmtu", NULL);
>  			fw3_ipt_rule_replace(r, "FORWARD");
> +
> +			r = fw3_ipt_rule_create(handle, &tcp, dev, NULL, NULL, sub);

I think this should be

 r = fw3_ipt_rule_create(handle, &tcp, dev, NULL, sub, NULL);

in order to turn -d subnet into -s subnet for the ingress rule.


~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200723/840a71d6/attachment.sig>