[RFC PATCH v2 1/6] ath79: ensure QCA956x gmac0 mux selects sgmii

Sander Vanheule sander at svanheule.net
Wed Jul 22 12:33:35 EDT 2020

Hi David,

On Wed, 2020-07-22 at 12:28 +0200, David Bauer wrote:
> Hi Sander,
> this looks good, however there are two minor improvements still open.
> > +	int err = 0;
> Remove this, as it is only assigned but never accessed.
> > +	u32 serdes_cal;
> This is never used.

I had copied the bulk of this function from the qca956x serdes init
function (patch 2/6), so I missed these when editing the code. Should
be all cleaned up now. Since the err variable was also unused in patch
2/6, I've removed it there too.

> I'll test this patch on my QCA9563 and QCA9561 devices and report
> back.

I've now tested it on my EAP245 v1 and v3. Both have a QCA9563, but
only the latter has the ethernet interface enabled correctly by the
bootloader (and didn't need this patch).


More information about the openwrt-devel mailing list