[PATCH 1/1] TARGET: Add new device support under target IPQ806x for Linksys E8350

[mail at adrianschmutzler.de]

> > + model = "Linksys EA8300 V1 WiFi Router";
>
> So, is it V1? Then add that to the compatible etc.: linksys,e8350-v1
> -> I've not sen V2 yet, so I can remove the versioning of this device in the updated patch.

Well, the question is not whether a v2 is there _yet_, but whether you are absolutely sure that there will never be a v2.

Otherwise, we will end up with linksys,e8350 and linksys,e8350-v2, which is not desirable, while having a lone linksys,e8350-v1 won't hurt.

> > + BOARD_NAME = e8350
> > + SUPPORTED_DEVICES += e8350
> Drop BOARD_NAME and SUPPORTED_DEVICES.
> -> what about the metadata generation, will it be affected?

Metadata will of course work, as this line is just adding _another_ string required for backwards compatibility. This second string e8350 is not used anywhere for this device, you just invented it by believing you were following a pattern.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200720/8b19d7b3/attachment.sig>