[PATCH 1/1] Fix Wifi Button - off function not working

mail at adrianschmutzler.de mail at adrianschmutzler.de
Sun Jul 19 18:58:10 EDT 2020

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Henrique de Moraes Holschuh
> Sent: Montag, 20. Juli 2020 00:51
> To: openwrt-devel at lists.openwrt.org
> Subject: Re: [PATCH 1/1] Fix Wifi Button - off function not working
> >   config_foreach wifi_rfkill_set wifi-device
> >   uci commit wireless
> I've always hated this "uci commit" in the wifi on/off button handling, it
> causes FLASH wear for no good reason IMHO.
> But that is orthogonal to this patch, of course.

Yes, but as you say it, I wonder whether we really need wifi here or reload_config if we touch uci config anyway.

Refering to your actual subject, for me pressing WiFi button has always been an extremely rare case, so I'm not too concerned about that flash wear personally.



> --
> Henrique de Moraes Holschuh
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200720/261ebca3/attachment.sig>

More information about the openwrt-devel mailing list