[RFC PATCH 6/7] ath79: support for TP-Link EAP225-Outdoor v1

[Sander Vanheule]

Hi Adrian,

On Fri, 2020-07-17 at 15:01 +0200, mail at adrianschmutzler.de wrote:
> Hi,
> 
> > diff --git a/target/linux/ath79/dts/qca9563_tplink_eap225od-v1.dts
> > b/target/linux/ath79/dts/qca9563_tplink_eap225od-v1.dts
> > new file mode 100644
> > index 0000000000..dcfdb7e524
> > --- /dev/null
> > +++ b/target/linux/ath79/dts/qca9563_tplink_eap225od-v1.dts
> > @@ -0,0 +1,21 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT /dts-v1/;
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> 
> in DTSI.

Fixed.


> > +
> > +#include "qca9563_tplink_eap2x5_1port.dtsi"
> > +
> > +/ {
> > +	compatible = "tplink,eap225od-v1", "qca,qca9563";
> 
> No abbreviations, please. Replace by tplink,eap225-outdoor-v1
> (everywhere).
> > +	model = "TP-Link EAP225-Outdoor v1";
> > +};
> > +
> > diff --git a/target/linux/ath79/image/generic-tp-
> > link.mk
> > b/target/linux/ath79/image/generic-tp-link.mk
> > index a4a14ed889..9ac24908fe 100644
> > --- a/target/linux/ath79/image/generic-tp-link.mk
> > +++ b/target/linux/ath79/image/generic-tp-link.mk
> > @@ -372,6 +372,16 @@ define Device/tplink_eap2x5_1port
> >    IMAGE/factory.bin := append-rootfs | tplink-safeloader factory |
> > pad-extra
> > 128  endef
> > 
> > +define Device/tplink_eap225od-v1
> > +  $(Device/tplink_eap2x5_1port)
> > +  DEVICE_MODEL := EAP225-Outdoor
> > +  DEVICE_VARIANT := v1
> > +  TPLINK_BOARD_ID := EAP225OD-V1
> > +  DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct
> > endef
> > +TARGET_DEVICES += tplink_eap225od-v1
> > +
> >  define Device/tplink_eap245-v1
> >    $(Device/tplink_eap2x5_1port)
> >    DEVICE_MODEL := EAP245
> > diff --git a/tools/firmware-utils/src/tplink-safeloader.c
> > b/tools/firmware-
> > utils/src/tplink-safeloader.c
> > index a20304150b..e38729eb8a 100644
> > --- a/tools/firmware-utils/src/tplink-safeloader.c
> > +++ b/tools/firmware-utils/src/tplink-safeloader.c
> > @@ -1291,6 +1291,35 @@ static struct device_info boards[] = {
> >  		.last_sysupgrade_partition = "file-system"
> >  	},
> > 
> > +	/** Firmware layout for the EAP225-Outdoor v1 */
> > +	{
> > +		.id     = "EAP225OD-V1",
> 
> Same as for the compatible, I'd use EAP225-OUTDOOR-V1 here (though
> it's not as important for me as the renames above).
> 

Fixed. I've replaced all occurences of eap225od with eap225-outdoor,
same for the uppercase ones to keep things consistent.


Best,
Sander