[RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

[Jo-Philipp Wich]

Hi,

> Changes:
>   - The device is created as a netifd bridge
>   - Bridge vlan sections should always refer to the bridge instead of
> automatically be applied to the first one
>   - Use = instead of . to mark tagging modifiers. "." is already used
> for vlan interface names and reusing it here creates ambiguity.
>   - Allow specifing pvid as a modifier instead of needing to create a
> separate port section.
> 
> The section names are optional, I chose to put them in to make it easier
> to modify the sections from scripts
> 
> What do you think?

First of all, I was reworking dsaconfig into a very similar direction for a v3
so overall I do like your proposal and I think it makes sense.

Specific points from my side:

- I dislike the equal sign syntax, colon would fit better imho
- For denoting pvid I used a trailing asterisk, like the old roboswitch config
- The bridge-vlan sections should be anonymous
- Bridge vlan filtering will be implicitely enabled as soon as at least one
  bridge-vlan section references a bridge device?


So my preferred configuration would look like (choosing list over option
notation for ports but that should have no code impact):

config device
	option name switch0
	option type bridge

config bridge-vlan
	option device switch0
	option vlan 1
	list ports 'lan1'
	list ports 'lan2:t'

config bridge-vlan
	option device switch0
	option vlan 2
	list ports 'wan:u'    # I think we also should support an explicit
                              # untag which is equivalent to no suffix

config bridge-vlan
	option device switch0
	option vlan 5
	list ports 'lan2:t*'  # The "*" denotes a PVID
	list ports 'lan3'

config bridge-vlan
	option device switch0
	option vlan 8
	list ports 'lan2:t'
	list ports 'lan4'

config bridge-vlan
	option device switch0
	option vlan 11
	list ports 'lan2:t'
	list ports 'lan4:t'


~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200715/a8a339ca/attachment.sig>