[RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Jo-Philipp Wich jo at mein.io
Tue Jul 14 13:05:05 EDT 2020


> [...]
> Isn't it conceptually more correct in this case for the vlan filtering
> to be configured as part of the "interface" in uci?
> Ie I configure an interface of type "bridge" which bridges the switch
> ports, then the vlan filtering is a configuration property of this
> interface (just like enabling igmp_snooping on a bridge interface)

the "config interface" section type already is quite overloaded with different
layer2 and layer3 configuration semantics which leads to confusion and quirks,
as can be seen e.g. with "option mtu" on top of PPPoE interfaces or "option
mac" on bridges.

I agree that this setting could conceptually make sense in a "config device"
section of type bridge, but with the VLAN filter settings being
multi-dimensional it does not fit very well into simple uci option values
without defining yet another micro format to declare VLAN / port memberships.

The proposed dsaconfig approach has been selected due to its similarity with
swconfig, it is easier to understand for people already used to swconfig and
even allows for some automatic configuration conversion to some extent.

I also do see it as a complementary higher level kind of configuration. It is
entirely opt-in and can be supplemented or superseded with per-interface and
per-device attributes that are implemented in netifd eventually.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200714/2ff5aa2e/attachment.sig>

More information about the openwrt-devel mailing list