[OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

mail at adrianschmutzler.de mail at adrianschmutzler.de
Sat Jul 11 19:23:40 EDT 2020


Hi,

since nobody else took care so far:

In my opinion, this does not solve a problem with OpenWrt, but with your particular use case.

However, we cannot cover each individual use case in our default settings.
Despite, it would be relatively easy to either keep that change locally or just not add the relevant files when doing a commit.

(Personally, I have 10+ files in my OpenWrt root I just never touch when working with git.)

So, I'm marking this a Rejected.

I hope you don't feel repelled and continue to contribute to the project.

Best

Adrian

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Catrinel Catrinescu
> Sent: Dienstag, 10. März 2020 13:33
> To: Adrian Schmutzler <mail at adrianschmutzler.de>; openwrt-
> devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> Hi Adrian
> 
> After successful testing, I always save the .config files, attaching the revision
> number, like .config_r12345.
> 
> And it is a cosmetic replacement too.
> 
> 
> Thanks
> Catrinel
> 
> 
> -----Original Message-----
> From: Adrian Schmutzler <mail at adrianschmutzler.de>
> Sent: Tuesday, 10 March 2020 13:26
> To: Catrinel Catrinescu <cc at 80211.de>; openwrt-devel at lists.openwrt.org
> Subject: RE: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> > On Behalf Of cc at 80211.de
> > Sent: Dienstag, 10. März 2020 13:02
> > To: openwrt-devel at lists.openwrt.org
> > Cc: Catrinel Catrinescu <cc at 80211.de>
> > Subject: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> Why is this necessary (-> commit message)?
> 
> Or is it just a cosmetic replacement of two lines by one? (In that case, I'd
> prefer the specific lines).
> 
> Best
> 
> Adrian
> 
> >
> > From: Catrinel Catrinescu <cc at 80211.de>
> >
> > Signed-off-by: Catrinel Catrinescu <cc at 80211.de>
> > ---
> >  .gitignore | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 6549af83be..edffba9c05 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -3,8 +3,7 @@
> >  .*.swp
> >  /env
> >  /dl
> > -/.config
> > -/.config.old
> > +/.config*
> >  /bin
> >  /build_dir
> >  /staging_dir
> > --
> > 2.17.1
> >
> >
> > _______________________________________________
> > openwrt-devel mailing list
> > openwrt-devel at lists.openwrt.org
> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200712/4f7da8a8/attachment.sig>


More information about the openwrt-devel mailing list