[OpenWrt-Devel] [PATCH] ramips: ethernet: turn off flow control

Petr Štetiar ynezz at true.cz
Fri Jan 31 10:51:54 EST 2020

Rosen Penev <rosenp at gmail.com> [2020-01-29 20:39:57]:


> On kernel.org, the ralink_soc variable is only used in arch/mips ,
> mainly under the ralink subdirectory.

correct, but your proposed patch can't be accepted as it is. You need to
handle only 0x0101 and 0x0103 cases, thus putting content of the register into
some variable and use switch/case to make the decision.

Then you're going to replace the 0x0101 and 0x0103 magic numbers with some
meaningful constants which would be perhaps very similar to the ralink_soc
ones, so in the end doing the same, but differently.

Anyway, both approaches are fine with me, do whatever you prefer.

> I don't think it should be used for the switch driver.

FYI we're talking here about a source file under ramips target, it's not in
the generic directory so it's unlikely, that it would be used in other
targets, that's why I've suggested ralink_soc as the simplest solution.

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list